Skip to content

[CI] Increase code coverage of iwyu and clang-tidy ci jobs #3469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 16, 2025
Merged

[CI] Increase code coverage of iwyu and clang-tidy ci jobs #3469

merged 15 commits into from
Jun 16, 2025

Conversation

@dbarker
Copy link
Member

@dbarker dbarker commented Jun 9, 2025 •
edited
Loading

Changes

  • Adds cmake cache initialization files for opentelemetry-cpp options in test_common/cmake
  • Run clang tidy in a matrix
    • all-options-abiv1-preview (ABI version 1 plus all the cmake options including preview features)
    • all-options-abiv2-preview (ABI version 2 plus all the cmake options including preview features)
  • Adds a warning limit for each clang-tidy job (this job will now fail if additional warnings are added)
  • Run iwyu in a matrix
    • all-options-abiv1 (no preview features)
    • all-options-abiv1-preview
    • all-options-abiv2-preview

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@netlify
Copy link

netlify bot commented Jun 9, 2025 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit e7de1bd
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/684fbe042fcd530008159507

@codecov
Copy link

codecov bot commented Jun 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.92%. Comparing base (7a68bb3) to head (e7de1bd).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3469   +/-   ##
=======================================
  Coverage   89.92%   89.92%           
=======================================
  Files         219      219           
  Lines        7042     7042           
=======================================
  Hits         6332     6332           
  Misses        710      710
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker dbarker changed the title Increase code coverage of iwyu and clang-tidy ci jobs [CI] Increase code coverage of iwyu and clang-tidy ci jobs Jun 9, 2025
@dbarker dbarker marked this pull request as ready for review June 9, 2025 20:43
@dbarker dbarker requested a review from a team as a code owner June 9, 2025 20:43
lalitb
lalitb reviewed Jun 9, 2025
View reviewed changes
@dbarker dbarker marked this pull request as draft June 10, 2025 20:09
@dbarker dbarker marked this pull request as ready for review June 11, 2025 14:16
marcalff
marcalff approved these changes Jun 12, 2025
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cmake cleanup.

marcalff
marcalff reviewed Jun 14, 2025
View reviewed changes
@marcalff
Copy link
Member

@dbarker See minor comment about preview options.

@marcalff marcalff merged commit 4561fc2 into open-telemetry:main Jun 16, 2025
70 checks passed
@dbarker dbarker deleted the ci_enable_more_cmake_options_with_qa_tools branch July 10, 2025 16:45
@BrewTestBot BrewTestBot mentioned this pull request Jul 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lalitb lalitb lalitb left review comments

@marcalff marcalff marcalff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dbarker @marcalff @lalitb